Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lbach
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: roycaihw

If they are not already assigned, you can assign the PR to them by writing /assign @roycaihw in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

I am having some issues registering with LinuxFoundation. I'll have the CLA signed once I get my account with LinuxFoundation sorted.

Codecov Report

Merging #121 into master will decrease coverage by 0.22%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   92.11%   91.88%   -0.23%     
==========================================
  Files          13       13              
  Lines        1217     1220       +3     
==========================================
  Hits         1121     1121              
- Misses         96       99       +3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e077f88...ec02f0c. Read the comment docs.

There's an issue with this patch. When applied, I get the following exception:

  File ".../site-packages/kubernetes/config/kube_config.py", line 215, in _load_azure_token
    expires_on_ts = int(provider['config']['expires-on'])
ValueError: invalid literal for int() with base 10: '2019-03-15 13:36:54.245657'

I'm new at this whole github contributing thing, but if you change the _load_azure_token(self, provider) function to the following, it fixes the ValueError: invalid literal for int() with base 10:

def _load_azure_token(self, provider):
    if 'config' not in provider:
        return
    if 'access-token' not in provider['config']:
        return
    if 'expires-on' in provider['config']:
        try:
             if time.gmtime(int(provider['config']['expires-on'])) < time.gmtime():
                self._refresh_azure_token(provider['config'])
        except ValueError:
            if time.strptime(provider['config']['expires-on'], '%Y-%m-%d %H:%M:%S.%f') < time.gmtime():
                self._refresh_azure_token(provider['config'])
    self.token = 'Bearer %s' % provider['config']['access-token']
    return self.token

Credit to @fatal-exception in #84

@lbach Any chance this can be finished? It'd be a huge help to us to have this working. Thanks!

#84 gets fixed by #141. Closing this in favor of that one

Verified this is broken in kubernetes==10.0.1 and working in prerelease kubernetes==11.0.0b2; looking forward to a GA release of 11.

@lbach: PR needs rebase.

Verified this is broken in kubernetes==10.0.1 and working in prerelease kubernetes==11.0.0b2; looking forward to a GA release of 11.

Thanks for the verification! We are working on releasing 11.0.0 GA. I added an item in the bi-weekly meeting agenda. cc @palnabarun